Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Change the "Debug" icon to align with the default VSCode menu item icon design #100

Closed
wenfangdu opened this issue Aug 26, 2021 · 4 comments · Fixed by #149
Closed

[Enhancement] Change the "Debug" icon to align with the default VSCode menu item icon design #100

wenfangdu opened this issue Aug 26, 2021 · 4 comments · Fixed by #149
Assignees
@mark-wiemer
Labels
enhancement new feature or request good first issue good for new contributors

Comments

@wenfangdu
Copy link

wenfangdu commented Aug 26, 2021 •
edited

The current "Debug" icon looks blurry and inconsistent with the default VSCode menu item icon design:

image

Compared to Code Runner's "Run Code" icon (crisp and consistent with the VSCode icon design):

image

Would be great to make it crisper and align with the default VSCode menu item icon design.

P.S. I'm not suggesting AHK++ should use Code Runner's icon.
@fade2gray
Copy link

This is how they look in my editors.
debug-icon

@mark-wiemer
Copy link
Collaborator

See #102 as well

@mark-wiemer mark-wiemer added the enhancement new feature or request label Jun 3, 2022
@mark-wiemer mark-wiemer added this to the Backlog milestone Jun 3, 2022
@mark-wiemer mark-wiemer added the good first issue good for new contributors label Jun 3, 2022
@mark-wiemer
Copy link
Collaborator

See also https://code.visualstudio.com/api/references/icons-in-labels for some sample icons provided by VS Code

@mark-wiemer
Copy link
Collaborator

mark-wiemer commented Jul 5, 2022 •
edited

Ah, much better. Now using the default debug-alt

image

image

This was referenced Jul 5, 2022
Merged
Closed
Merged
mark-wiemer added a commit that referenced this issue Jul 5, 2022
@mark-wiemer
v2.8.3 (#150)
2bcbf27 
-   Change to use default debug icon ([#100](#100))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mark-wiemer mark-wiemer

Labels
enhancement new feature or request good first issue good for new contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use default debug icon mark-wiemer-org/ahkpp
3 participants
@fade2gray @mark-wiemer @wenfangdu