Add support for rails 3

[smtlaissezfaire]

No description provided.

[mattherick]

does it support rails 3 already? if not, is there a fork or other repo available? anyone an idea?

[smtlaissezfaire]

I haven't hacked on this project for a while. - so there is no explicit support for it yet (although as always, patches welcome!)

Check out the garlic.rb file and https://github.com/markaby/markaby/blob/master/lib/markaby/rails.rb#L24

We should probably drop rails 1.x support and possibly even 2.x support and just get 3.x working going forward.

[judofyr]

I've been working on https://github.com/camping/mab/ (which is a re-implementation of Markaby). Considering adding Rails 3 support…

[smtlaissezfaire]

Cool. I'd totally support it and shut this project down if we can get the test suite running there (feature parity, minus rails 1.x and 2.x support, but plus 3.x support going forward).

[mattherick]

• 1, very cool!

[judofyr]

Mab isn't 100% API compatible with Markaby (e.g. Mab escaped #text, Markaby doesnt), but they're small enough that you could write a very light compat layer.

[smtlaissezfaire]

Out of curiosity, why port it instead of just fixing it (aside from the escaping change)?

[judofyr]

The main goal of Mab (or really, Rumble) was to allow mixing it into other classes:

class Hello
  include Mab::Mixin

  def render
    mab { strong @title }
  end
end

It seemed simpler to start from scratch (it's about ~200 LoC now) than to change Markaby completely.

[smtlaissezfaire]

Oh. Isn't this what the kernel method does?

https://github.com/markaby/markaby/blob/master/lib/markaby/kernel_method.rb

Couldn't we just make that into a mixin instead of adding it directly to kernel?

[smtlaissezfaire]

But yeah - if it runs a lot faster I'm all for it. Markaby seems to have a lot of layers and runs pretty slowly, so as long as it's mostly compatible and has rails support I'm a go.

[judofyr]

@mattherick: I've pushed out a new version of Mab (0.0.3) that supports Rails. Simply require "mab" at the top of your application.rb and you should be able to use foo.html.mab-templates. Please report issues at https://github.com/camping/mab/issues if you find any bugs or have any feature requests! Mab is still very young, but I'm able to release fixes pretty quickly :-)

[mattherick]

@judofyr: Thx for the quick update!

[mattherick]

@judofyr: is your solution also ruby 1.9 compatible? If not, is it much work to get it compatible?

[judofyr]

Yes, it's 1.9 compatible.

[smtlaissezfaire]

Closing this. @judofyr I've given you commit access. Not sure if you are still using markaby or if you are using mab. I'm starting to work on markaby again as I'm using it in a rails project.