Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to multiplatform #36

Merged
merged 3 commits into from Jul 31, 2019
Merged

Conversation

Dominaezzz
Copy link
Contributor

So I've setup a multiplatform project with only a JVM target for now.
I expect we'll gradually move components to the common source set .... until we can't.
Then we'll look at viable abstractions.

There's one tiny gotcha. The play button IntelliJ offers when looking at a sample file won't work anymore because of a bug in IntelliJ (about resource handling) we discussed.
So I've created a gradle task for each sample to run them.

@markaren
Copy link
Owner

Will check it out!

@markaren
Copy link
Owner

First the IDE was not able to find any three.kt classes. Everything red. This I fixed by selecting the "use separate modules per source sets" option. However, I can't run the examples either through run file or using the tasks you made. I get Error: Could not find or load main class ...

@markaren
Copy link
Owner

I could push #29 forward to (partly) resolve the resource issue

@Dominaezzz
Copy link
Contributor Author

Hmm, I did gradle clean then gradle runBasicSample and it still works.
Can I see the full output of the two commands?

@markaren
Copy link
Owner

Task :examples:runBasicExample FAILED
Error: Could not find or load main class info\laht\threekt\BasicExample
Caused by: java.lang.NoClassDefFoundError: info/laht/threekt/BasicExample (wrong name: info\laht\threekt\BasicExample)
Error: Could not find or load main class info\laht\threekt\BasicExample



Caused by: java.lang.NoClassDefFoundError: info/laht/threekt/BasicExample (wrong name: info\laht\threekt\BasicExample)

Running with --stacktrace crashes. Dunno if that's related.

@Dominaezzz
Copy link
Contributor Author

Oh, you're not on Linux. I made a terrible assumption about path separators. 😅

@markaren
Copy link
Owner

That was better!

@markaren
Copy link
Owner

With the README update I pushed I think we can merge this and slowly improve it.

@markaren markaren merged commit 4583c57 into markaren:master Jul 31, 2019
@Dominaezzz Dominaezzz deleted the multiplatform branch July 31, 2019 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants