Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug in store.retrieve #34

Closed
jamesthecmo opened this issue Aug 30, 2012 · 0 comments
Closed

Possible bug in store.retrieve #34

jamesthecmo opened this issue Aug 30, 2012 · 0 comments

Comments

@jamesthecmo
Copy link

Hey, I was just trying to use the retrieve method and ran into a potential issue.

It first does method_missing to get a value and then checks if it is a store, if so it returns the default.

Is that intended?

For instance, I have nested fields, and some of them are supposed to be stores, and instead of getting the value, I get nil because I did not specify a default.

Should it be:

return (val.is_a?(Configatron::Store) && val.nil?) ? default_value : val

or

vreturn val.nil? ? default_value : val

instead of

return val.is_a?(Configatron::Store) ? default_value : val

Maybe I am misunderstanding the usage of that method. I worked around it by calling method_missing myself and checking for nil.

Thanks for a great library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants