Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Possible bug in store.retrieve #34

Closed
jamesthecmo opened this Issue · 0 comments

2 participants

jamesthecmo Mark Bates
jamesthecmo

Hey, I was just trying to use the retrieve method and ran into a potential issue.

It first does method_missing to get a value and then checks if it is a store, if so it returns the default.

Is that intended?

For instance, I have nested fields, and some of them are supposed to be stores, and instead of getting the value, I get nil because I did not specify a default.

Should it be:

return (val.is_a?(Configatron::Store) && val.nil?) ? default_value : val

or

vreturn val.nil? ? default_value : val

instead of

return val.is_a?(Configatron::Store) ? default_value : val

Maybe I am misunderstanding the usage of that method. I worked around it by calling method_missing myself and checking for nil.

Thanks for a great library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.