Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

state for all providers? #35

Closed
ghost opened this issue Aug 21, 2015 · 5 comments
Closed

state for all providers? #35

ghost opened this issue Aug 21, 2015 · 5 comments

Comments

@ghost
Copy link

ghost commented Aug 21, 2015

does goth have a common story for setting additional session params for the providers that do not support oauth2's state parameter?

@ghost
Copy link
Author

ghost commented Aug 21, 2015

a twitter response suggested adding params to the "oauth_callback" callback to track state, but since goth providers use sessions, maybe that's the ideal place to lookup a state value in oauth callbacks?

@markbates
Copy link
Owner

The point of the session is track stuff across all of the requests, so that would be the place to put any of that type of data.

@ghost
Copy link
Author

ghost commented Aug 21, 2015

@markbates right. is there a recommended approach to using the provider sessions? I want to track a property with the twitter auth session to be used on successful callbacks. there doesn't look like any place to add that to the twitter session, or any convenience methods. At this point to do this, are we implementing our own twitter provider to do this?

@markbates
Copy link
Owner

You would have to add some convenience methods to the API to let you hook into it. Shouldn't be that hard though. I would welcome the PR.

@ghost
Copy link
Author

ghost commented Aug 21, 2015

@markbates thanks, that's what I was wondering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant