Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Dark theme #60

Open
ilyagr opened this issue Aug 12, 2023 · 1 comment
Open

FR: Dark theme #60

ilyagr opened this issue Aug 12, 2023 · 1 comment

Comments

@ilyagr
Copy link

ilyagr commented Aug 12, 2023

First of all, thanks for making streampager, it's really neat!

IMO, streampager looks great on a terminal with a light background and pretty bad on a terminal with a dark background. (See below for screenshots)

I'm thinking of implementing a much more simplistic version of #56 in the form of a dark theme. I am thinking of a theme config with possible values light, dark, and maybe auto. This would likely work for me as a replacement for #56, but could also comfortably coexist with the more elaborate configuration suggested in #56.

My current plan for the dark theme would be to have the status bar be white text on a dark-grey background instead of the current black-on-silver. This might change as I try differnet things. I'd also want the dark theme to be readable even on a terminal with a light background (if not necessarily beautiful).

The auto theme, if it is desired, would use something like https://github.com/dalance/termbg to try to pick the theme automatically.

Current theme (would be light):

image

(The bar looks even lighter in the default xterm theme)

image

On dark background, the light bar is somewhat distracting.

image

First pass at dark theme (normal color on dark grey option)

image

The dark theme on light background doesn't look as good as light theme, but still OK. The user should never see it.

image

TODO: Show black on blue

@ilyagr
Copy link
Author

ilyagr commented Aug 12, 2023

I'd also appreciate comments of whether others would find this useful. It's possible that having just a dark and a light theme is not enough of an improvement to be worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant