Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsupported conditions for numberinwords #18

Open
echan00 opened this issue May 10, 2019 · 1 comment
Open

Unsupported conditions for numberinwords #18

echan00 opened this issue May 10, 2019 · 1 comment

Comments

@echan00
Copy link

echan00 commented May 10, 2019

Sorry, I'm not sure what the correct terminology to explain the issue below but it is likely something the library can improve upon

NumbersInWords.in_numbers("half a million dollars")
=> 1000000
NumbersInWords.in_numbers("a quarter million dollars")
=> 1000000

@markburns
Copy link
Owner

I’d support this after support for fractions were implemented. The only caveat being that I wouldn’t see the gem supporting stripping out dollars from the string. You’d have to do that first.

Big caveat, as this project is effectively a Sunday crossword for me, and I’ve got family and plenty of other commitments, I’m personally very unlikely to get around to this any time soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants