Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http client timeout should be set to non-infinity default #2

Closed
kriptor opened this issue Jan 22, 2018 · 1 comment
Closed

http client timeout should be set to non-infinity default #2

kriptor opened this issue Jan 22, 2018 · 1 comment

Comments

@kriptor
Copy link

kriptor commented Jan 22, 2018

Inside quote.go client := &http.Client{} is used but we should have some sane timeout setting there. E.g.: client := &http.Client{Timeout: 10 * time.Second}

Even better, there should probably be a way to inject your own http client.

@markcheno
Copy link
Owner

Good idea, added it in all the calls.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants