Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

step.bind() framework does not work on iOs5 #22

Closed
synthview opened this issue Sep 12, 2013 · 6 comments
Closed

step.bind() framework does not work on iOs5 #22

synthview opened this issue Sep 12, 2013 · 6 comments

Comments

@synthview
Copy link

Hello,
I've read the this topic #2 where you say the issue is in the site not in the framework.

I’m using your original bespoke.js file and trying to add buttons to make the desk’s cards slide but on iOs5 bespoke.next(); breaks the js at step.bind() (into bespoke.js).

If you could fix it fast it would be great :) there are still many devices using iOs5…
Thanks

@markdalgleish
Copy link
Member

iOS5 is missing Function#bind, so a simple fix is to include es5-shim.

@synthview
Copy link
Author

Thanks, I'm not a js ninja, is there a way to make only older webkit to load it?

@synthview
Copy link
Author

or maybe use a jquery command, as I use jquery on the same page?

@markdalgleish
Copy link
Member

Since you're already using jQuery, it wouldn't be a big deal to include the bind polyfill on its own for everyone.

@synthview
Copy link
Author

well, I've tried to import es5-shim and after this, to add the the jquery bind polyfill code but none worked as now
I see a new error in console:
TypeError: Result of expression 'el.classList' [undefined] is not an object.

@synthview
Copy link
Author

Ooops, sorry, it works on iOs5! It doesn't with Mac Safari 4, but who cares about that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants