Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should have a way to select children (by class) #26

Closed
knownasilya opened this issue Oct 11, 2013 · 4 comments
Closed

Should have a way to select children (by class) #26

knownasilya opened this issue Oct 11, 2013 · 4 comments

Comments

@knownasilya
Copy link

The reason I mention this, is because at the moment it's assumed that all the children of the node are slides, but that might not be the case. For example, ember inserts script tags around bound values, and this interferes with bespoke.

Adding the class name as an option would be nice.

@markdalgleish
Copy link
Member

Interesting. Do you have a demo of this that I can look at? In what scenario would Ember be interfering with slide elements?

@knownasilya
Copy link
Author

I'll whip-up a jsbin as an example.

@knownasilya
Copy link
Author

Here's a basic example, and I think I've done everything correct :)

@markdalgleish
Copy link
Member

Rather than implementing the solution you described, v0.4.0 now ignores script tags when selecting slide elements.

Let me know if this fixes the problem for you, otherwise feel free to re-open the issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants