Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links aren't clickable in Firefox #43

Closed
strugee opened this issue Aug 19, 2014 · 4 comments
Closed

Links aren't clickable in Firefox #43

strugee opened this issue Aug 19, 2014 · 4 comments

Comments

@strugee
Copy link

strugee commented Aug 19, 2014

When a Bespoke.js presentation is viewed in Firefox, and presumably all Gecko-based UAs, links aren't clickable. I have no idea why. Chrome does not have this problem.

I see nothing obvious in the console. Perhaps this is caused by a preventDefault() somewhere? I don't know.

@strugee
Copy link
Author

strugee commented Aug 19, 2014

For reference, I used the yo generator. Here's my main.js:

// Require Node modules in the browser thanks to Browserify: http://browserify.org
var bespoke = require('bespoke'),
  cube = require('bespoke-theme-cube'),
  keys = require('bespoke-keys'),
  touch = require('bespoke-touch'),
  bullets = require('bespoke-bullets'),
  scale = require('bespoke-scale'),
  hash = require('bespoke-hash'),
  progress = require('bespoke-progress'),
  state = require('bespoke-state');

// Bespoke.js
bespoke.from('article', [
  cube(),
  keys(),
  touch(),
  bullets('li, .bullet'),
  scale(),
  hash(),
  progress(),
  state()
]);

I can also reproduce this problem with Build Wars: Gulp vs. Grunt.

@markdalgleish
Copy link
Member

Thanks for highlighting this.

The issue is that the .bespoke-scale-parent elements are positioned absolutely and are blocking clicks on the slides.

The fix is to set pointer-events: none on these elements, and set pointer-events: auto on the active slide. For reference, see the 'Fix links in Firefox' commit from the 'Build Wars' repo.

I'll apply this fix to the generator and update the bespoke-scale readme. Since this issue isn't actually with the core library, I'm closing this issue.

@markdalgleish
Copy link
Member

This issue has been fixed in generator-bespoke, generator-bespoketheme, bespoke-theme-cube and bespoke-theme-voltaire.

@strugee
Copy link
Author

strugee commented Aug 20, 2014

Works for me, thanks!

strugee added a commit to redshiftrobotics/presentation-robotc-basics that referenced this issue Nov 1, 2014
There's a weird bug related to bespokejs/bespoke#43.
Requires further investigation, but in the meantime, I have a
presentation to give. Hence, npm shrinkwrap --dev.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants