resolves #60 introduce off method to unbind an event #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mojavelinux
force-pushed
the
issue-60
branch
from
5f1bb1f
to
f63e1b6
Compare
|
Looks great. Happy to merge this once the conflicts are resolved. |
|
I'll get right on it. Stay tuned! |
mojavelinux
force-pushed
the
issue-60
branch
from
f63e1b6
to
8aab0ae
Compare
|
Rebase complete! |
markdalgleish
added a commit
that referenced
this pull request
Sep 22, 2015
Introduce off method to unbind an event, resolves #60
|
🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it turns out, we can add this method without any additional lines of code (and only a slight increase in the gzipped version). The
onmethod can reuse theoffmethod when building the return value by leveragingbind.