Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should the type of node.type be NodeType instead of string #119

Closed
matv-stripe opened this issue Jul 8, 2022 · 2 comments · Fixed by #120
Closed

Should the type of node.type be NodeType instead of string #119

matv-stripe opened this issue Jul 8, 2022 · 2 comments · Fixed by #120
Assignees
@rpaul-stripe

Comments

@matv-stripe
Copy link
Contributor

Currently this is a string:

markdoc/src/ast/node.ts

Line 21 in 98dd883

type: string;

Should these be of this type?
https://github.com/markdoc/markdoc/blob/main/src/types.ts#L60
@mfix-stripe
Copy link
Contributor

mfix-stripe commented Jul 11, 2022 •
edited

Should these be of this type?
https://github.com/markdoc/markdoc/blob/main/src/types.ts#L60

I think we can make this type: NodeType | 'node' | 'tag' | 'error'. WDYT @rpaul-stripe?

@mfix-stripe
Copy link
Contributor

Or we could add 'node' | 'tag' | 'error' to NodeType

@mfix-stripe mfix-stripe mentioned this issue Jul 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rpaul-stripe rpaul-stripe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[RFC] Add node, tag, and error to NodeType markdoc/markdoc
3 participants
@rpaul-stripe @matv-stripe @mfix-stripe