Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal link formatting has a few problems #231

Closed
jvsteiner opened this issue Apr 29, 2023 · 4 comments
Closed

Internal link formatting has a few problems #231

jvsteiner opened this issue Apr 29, 2023 · 4 comments

Comments

@jvsteiner
Copy link
Contributor

So I tried out the new feature of supporting links internally within a document and it doesn't work properly in my case. I noticed the following:

for a link that started out life as:

[[note-filename#Target Header|Visible link Text]] - in obsidian

I ended up with a rendered link, in confluence that looks like this:

https://my.domain.net//wiki/spaces/NC/pages/6767676767#Target%20Header

  1. There are two slashes after the domain, and before wiki in the path
  2. There is not any slash after the pageid, and before the fragment (#)
  3. The space is rendered still as %20 and not converted to a - as per confluence norms

When I fixed these manually the link worked, but not before

@andymac4182
Copy link
Member

Thanks. I'll have another look. I should of known better than trying to just push a quick fix without testing it.

@jvsteiner
Copy link
Contributor Author

  1. above might be related to Links in the status modal dont work #230

@andymac4182 andymac4182 transferred this issue from markdown-confluence/obsidian-integration Apr 29, 2023
@andymac4182
Copy link
Member

Next attempt. This time I didn't rush and look at the wrong place ed446e8

@andymac4182
Copy link
Member

Will leave the settings issue with the domain to the other issue. Fixed up the # links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants