-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modularity of core #172
Comments
https://markdown-it.github.io/markdown-it/#Ruler You already can inject your plugin rules before/after some. Anything wrong with that? |
Maybe... the core, which is this project, processes I guess better questions:
I appreciate your feedback as I'm still learning how to assist others with their plugins and perhaps writing one myself. :) |
No. You need to inject your plugin with more high proirity than existing one to consume such content.
Yes. |
So I might be able to change the priority of the core to be later then?... e.g. postponing? (getting my terminology in sync with yours here) Alright... I'll do some twiddling after the holiday here and see if I can get that plugins issue fixed as it's nearly exactly what we're looking for. I'd rather not blacklist If it's alright with you can I keep this issue open? I'll scour over the API very soon and see if my objective, and the reporters too, can be achieved. |
I'd prefer to close it, because such common issues without clear resolution have tendency to be "endless". It's better to create a new one when needed. I think, after digging code, docs & existing plugins in npm, the number of your question will decrease significantly. |
One trick of the trade is to use HTML entities too... so the markdown-it-flowdock plugin might be able to set the |
It's better to create a new token with separate renderer. |
Alright.... plenty to "chew" on here... closing... Thanks for your assistance. :) |
So I was investigating flowdock/markdown-it-flowdock#3 and it would appear that markdown-it (and so is marked package with a false "hit") is handling
_emphasis_ markdown syntax
first then that package is failing with a "miss" since it is a post operation.Hopefully not presuming too much... I can possibly see some logic alternatives to fix this:
a
nchor tags withtextContent
.use
them in whatever priority we choose. Still may present as an issue witha
nchor tags withtextContent
._
and we already blacklist*
... this may break other sites if adopted and definitely going to confuse all users including ours when I go around and renaming their account with an announcement.Any thoughts on this from this upstream here and downstream there?
The text was updated successfully, but these errors were encountered: