Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links are broken when containing parenthesis character ")" #354

Closed
x9t9 opened this issue May 9, 2017 · 4 comments
Closed

Links are broken when containing parenthesis character ")" #354

x9t9 opened this issue May 9, 2017 · 4 comments
Labels

Comments

@x9t9
Copy link

x9t9 commented May 9, 2017

Expected behavior :

Valid and safe URL's pasted or written should be converted to functional links ( as-is ) .

Actual behavior :

Valid and safe URL's that contain the parenthesis closing character " ) " without pairing are immediately broken at the point of said character .

Steps to reproduce :

  • Open the markdown-it demo
  • Paste a URL ( or write one )
  • Manually add a closing parenthesis character in the link " ) " without a matched opening one .

Note : As per my understanding , the parenthesis character " ) " IS considered safe and valid as per rfc3986 ( see also here and here )

@puzrin puzrin added the wontfix label May 10, 2017
@puzrin
Copy link
Member

puzrin commented May 10, 2017

That's a result of linkifier work. And it has reasons to consider unpaired ")" as outer char. If you don't like it - you can always define link explicit via markdown syntax.

PS. online demos has possibility to create permalinks. Real example is better that description of steps to reproduce.

@puzrin puzrin closed this as completed May 10, 2017
@x9t9
Copy link
Author

x9t9 commented May 10, 2017

@puzrin I am not sure I understand why this was closed ( is it because the description or because it is not a bug or because it is in the wrong place ) and also what you mean by define link explicit .
In every way that I tried , the following link is somewhat broken ( as display or link itself )

http://stadtplan2.dresden.de/(S(p5l1235ice3cj3lspsbkmdnb))/spdd.aspx?TH=GA_KLG

Is that the real example you were referring to ?

@puzrin
Copy link
Member

puzrin commented May 10, 2017

Because that's not a markdown-it bug, and if you define your link according to commonmark spec, it will work as expected. That may be considered as linkify-it it bug, but it's known and nobody can give you 100% guarantee for heuristic anyway. If you need 100% guarantee, you should format links with commonmark syntax as described in spec.

Is that the real example you were referring to ?

The best way to show example

@x9t9
Copy link
Author

x9t9 commented May 10, 2017

Understood .
Sorry for missing that permalink tab link .. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants