-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Links are broken when containing parenthesis character ")" #354
Comments
That's a result of linkifier work. And it has reasons to consider unpaired ")" as outer char. If you don't like it - you can always define link explicit via markdown syntax. PS. online demos has possibility to create permalinks. Real example is better that description of steps to reproduce. |
@puzrin I am not sure I understand why this was closed ( is it because the description or because it is not a bug or because it is in the wrong place ) and also what you mean by define link explicit .
Is that the real example you were referring to ? |
Because that's not a markdown-it bug, and if you define your link according to commonmark spec, it will work as expected. That may be considered as linkify-it it bug, but it's known and nobody can give you 100% guarantee for heuristic anyway. If you need 100% guarantee, you should format links with commonmark syntax as described in spec.
|
Understood . |
Expected behavior :
Valid and safe URL's pasted or written should be converted to functional links ( as-is ) .
Actual behavior :
Valid and safe URL's that contain the parenthesis closing character
" ) "
without pairing are immediately broken at the point of said character .Steps to reproduce :
" ) "
without a matched opening one .Note : As per my understanding , the parenthesis character
" ) "
IS considered safe and valid as per rfc3986 ( see also here and here )The text was updated successfully, but these errors were encountered: