Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linkify terminating url - requires upgrade? #518

Closed
llamamoray opened this issue Nov 28, 2018 · 2 comments
Closed

Linkify terminating url - requires upgrade? #518

llamamoray opened this issue Nov 28, 2018 · 2 comments

Comments

@llamamoray
Copy link

llamamoray commented Nov 28, 2018

Hi,

When I have markdown:
https://www.test.com/_Think%20Italic_
markdown-it seems to terminate the link at https://www.test.com/
See: example

I've tried this in the the linkify-it playground and it correctly converts the whole url.

Having written a unit test and looking at the code I can see that it's incorrectly tokenising the url when the url contains text surrounded in underscore characters.

By the time the tokenized url gets here it's already terminated before the underscore.

@puzrin
Copy link
Member

puzrin commented Nov 30, 2018

That's a known issue, when underscores are processed as italic. Example. You can search previous tickets for details.

Workaround is to use < > brackets or add \ escape to some _. Better fix possible, but not easy, and not planned.

@puzrin puzrin closed this as completed Nov 30, 2018
@llamamoray
Copy link
Author

previous discussion in #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants