Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GFM Notes #974

Closed
calumk opened this issue Nov 20, 2023 · 2 comments
Closed

Support GFM Notes #974

calumk opened this issue Nov 20, 2023 · 2 comments

Comments

@calumk
Copy link

calumk commented Nov 20, 2023

I dont know if this would be best as a plugin or native

GFM allow for markup such as :

Important

This is an important note

Warning

This is a warning

https://github.com/orgs/community/discussions/16925

It is not the same format used by the containers plugin : https://mdit-plugins.github.io/container.html

@rlidwka
Copy link
Member

rlidwka commented Nov 20, 2023

This is absolutely a plugin.

markdown-it supports commonmark standard only at this point. There are a few inconsistencies between it and gfm, because of which we don't want to get into business of supporting that (gfm wasn't even a standard last I checked).

I think gfm is being implemented as a plugin by other people, maybe ask there.

Note

oh that's a cool feature, didn't know it existed
not sure if it's gonna make github issues better or worse if people are going to spam it

@calumk
Copy link
Author

calumk commented Nov 20, 2023

If it will be best suited as a plugin, I will referenced by other issues, and I will close this

@calumk calumk closed this as completed Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants