Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When ignoring MD033no-inline-html, MD034no-bare-urls always triggers in urls inside html tags #435

Open
WurmD opened this issue Nov 5, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@WurmD
Copy link

WurmD commented Nov 5, 2022

Description

The MD034no-bare-urls rule does not work inside html tags, it always triggers even if the url is not bare

Environment

Conda environment, python 3.8.13
MDL Version: 0.11.0

Expected Behavior

With MD033no-inline-html rule ignored, the following should pass

<details>
  <summary>Terraform:</summary>

1. [Install Terraform](<https://developer.hashicorp.com/terraform/tutorials/aws-get-started/install-cli>)
1. ...

</details>

Actual Behavior

README.md:4: MD034 Bare URL used

Replication Case

mkdir MDtest
cd MDtest
create README.md with

<details>
  <summary>Terraform:</summary>

1. [Install Terraform](<https://developer.hashicorp.com/terraform/tutorials/aws-get-started/install-cli>)
1. ...

</details>
cat > .pre-commit-config.yaml << EOF
---
default_language_version:
  python: python3.9

repos:
- repo: https://github.com/markdownlint/markdownlint.git
  rev: v0.11.0
  hooks:
  - id: markdownlint
    args: ["-r", "~MD033"]   # MD033: Allow "Inline HTML"
EOF

git init .
git add .
pre-commit run --all
@WurmD WurmD added the bug Something isn't working label Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant