Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization of self.cI #11

Open
NoraAl opened this issue Dec 25, 2022 · 1 comment
Open

Optimization of self.cI #11

NoraAl opened this issue Dec 25, 2022 · 1 comment

Comments

@NoraAl
Copy link

NoraAl commented Dec 25, 2022

Thank you for sharing the reimplementation and for the clean and organized code. There is an issue with the state of the meta learner self.cI. It is created as a parameter of the metalarner, and thusly getting optimized by Adam here. It should be passed as a state to avoid such behavior.

Thanks

@NoraAl
Copy link
Author

NoraAl commented Dec 26, 2022

A quick fix is to freeze those parameters to avoid potential updates. A pull request has been created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant