fix: the exports not define types #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user use the ts and set `moduleResolution: nodenext` of `tsconfig.json`, this type will not be available.
github-actions bot
pushed a commit
that referenced
this pull request
Dec 4, 2023
## [2.0.9](v2.0.8...v2.0.9) (2023-12-04) ### Bug Fixes * define types in exports ([#179](#179)) ([ae5af26](ae5af26))
|
🎉 This PR is included in version 2.0.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user use the ts and set
moduleResolution: nodenextoftsconfig.json, this type will not be available.https://github.com/NWYLZW/How-to-publish-a-npm-package/blob/c1be086a620e0d594c014bcfa910cc1e3a79a56e/tests/marked-highlight/index.ts#L1
So we should set the
typesfield forpackage.json:exports:[.].The new support works similarly with import conditions. By default, TypeScript overlays the same rules with import conditions - if you write an import from an ES module, it will look up the import field, and from a CommonJS module, it will look at the require field. If it finds them, it will look for a corresponding declaration file. If you need to point to a different location for your type declarations, you can add a "types" import condition.[1]
[1] TypeScript 4.7 ChangeLog