Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://marked.js.org/ has confusing links #1167

Closed
vsemozhetbyt opened this issue Mar 27, 2018 · 7 comments
Closed

https://marked.js.org/ has confusing links #1167

vsemozhetbyt opened this issue Mar 27, 2018 · 7 comments

Comments

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Mar 27, 2018

Some links in https://marked.js.org/ refer to .md files. This may be confusing and the files are hardly readable.

Some of these links have their .html counterparts on the site, some have not.

https://marked.js.org/USING_ADVANCED.md
(https://marked.js.org/USING_ADVANCED.html exists)

https://marked.js.org/USING_PRO.md
(https://marked.js.org/USING_PRO.html exists)

https://marked.js.org/AUTHORS.md
(https://marked.js.org/AUTHORS.html exists)

https://marked.js.org/CONTRIBUTING.md
(https://marked.js.org/CONTRIBUTING.html is 404)

@UziTech
Copy link
Member

UziTech commented Mar 27, 2018

Weird, I'm not sure where the .html files are coming from. @styfle aren't the docs hosted from /docs?

@styfle
Copy link
Member

styfle commented Mar 27, 2018

@UziTech Correct.

The reason why the html files exist is because GitHub Pages builds the docs with jekyll on each push to this folder (on the master branch).

It's a convenience feature that we don't really need because we are using marked to render the .md files on the fly.

Which part is confusing about the links?

@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Mar 27, 2018

Confusing is that the main rendered HTML page refers to the .md sources which are hard to read.

@vsemozhetbyt
Copy link
Contributor Author

For example, in this sentence:

Marked offers advanced configurations and extensibility as well.

both links refer to unrendered .md files.

@styfle
Copy link
Member

styfle commented Mar 27, 2018

Ok thanks 👍

I see two points of confusion:

  1. Opening the link in the new window shows the .md source which is unexpected
  2. Opening the link in the same window doesn't update the URL so its not clear you're on a new "page"

Did that describe your problem?

@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Mar 27, 2018

Oh, I did not even know that I can navigate inside a page. I usually open links in a new tab.

Yes, and maybe:
3. Opening the link in the same window doesn't update the history so readers cannot go back with the "Back" browser button (they need to reload the page).

@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Mar 27, 2018

And if a reader mixes #hash navigation with re-render trick navigation the history navigation becomes very confusing.

@UziTech UziTech mentioned this issue Mar 27, 2018
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants