Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the option : headerIds is not valid. #1208

Closed
junixapp opened this issue Apr 9, 2018 · 3 comments
Closed

the option : headerIds is not valid. #1208

junixapp opened this issue Apr 9, 2018 · 3 comments

Comments

@junixapp
Copy link

junixapp commented Apr 9, 2018

markd: 0.3.19:
when i set headerIds: false,but it still generated the ids for per element.

@UziTech
Copy link
Member

UziTech commented Apr 9, 2018

I don't believe the headerIds option was added to a release yet

/cc @joshbruce

@joshbruce
Copy link
Member

joshbruce commented Apr 9, 2018

Believe @li-xiaojun is referring to the feature that is already in place. The only change we made was to make it so you could disable it (not part of a release yet). The default behavior is to add header ids. We've always had issues with UTF-8 characters; see #981.

(edit): Sorry, thought I was looking #1209 - @UziTech is correct - we have not actually released the ability to disable header IDs yet. This and the comment made in #1209 is why I've actually recommended deprecating the feature doing 1.x or 2.x - it's a difficult thing for Marked to take on in an appropriate manner. #1115

@styfle styfle added this to the 0.4.0 - No known defects milestone Apr 30, 2018
@styfle
Copy link
Member

styfle commented Apr 30, 2018

Hi @li-xiaojun sorry for the confusion 😄

Our docs are based off of master which includes this new headerIds option however it is not released yet. Our next release, 0.4.0 will include it (as the other team members mentioned above).

If you're feeling adventurous, you could try out the code in the master branch before the release.

We'll close this issue when 0.4.0 gets released. Thanks! 👍

@styfle styfle mentioned this issue Apr 30, 2018
4 tasks
@joshbruce joshbruce mentioned this issue May 20, 2018
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants