Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table render error #1290

Closed
LoeiFy opened this issue Jun 11, 2018 · 3 comments · Fixed by #1262
Closed

table render error #1290

LoeiFy opened this issue Jun 11, 2018 · 3 comments · Fixed by #1262
Labels
L2 - annoying Similar to L1 - broken but there is a known workaround available for the issue

Comments

@LoeiFy
Copy link

LoeiFy commented Jun 11, 2018

This markdown

| 参数 | 说明 | 类型 | 可选值 | 默认值 |
| --- | --- | --- | --- | --- |
| itemRender | 自定义链接函数,和 react-router 配置使用 | (route, params, routes, paths) => ReactNode |  | - |
| params | 路由的参数 | object |  | - |
| routes | router 的路由栈信息 | object\[] |  | - |
| separator | 分隔符自定义 | string\|ReactNode |  | '/' |

Will be rendered by Marked as ( Marked Version : 0.4.0 )

screen shot 2018-06-11 at 8 56 07 pm

Actually it should be

参数 说明 类型 可选值 默认值
itemRender 自定义链接函数,和 react-router 配置使用 (route, params, routes, paths) => ReactNode -
params 路由的参数 object -
routes router 的路由栈信息 object[] -
separator 分隔符自定义 string|ReactNode '/'
@UziTech
Copy link
Member

UziTech commented Jun 11, 2018

I believe this is fixed by #1262

@UziTech UziTech added the L2 - annoying Similar to L1 - broken but there is a known workaround available for the issue label Jun 11, 2018
@UziTech
Copy link
Member

UziTech commented Jun 11, 2018

it happens because the 4th cells are empty

@UziTech UziTech mentioned this issue Jun 11, 2018
4 tasks
@Martii
Copy link
Contributor

Martii commented Jun 12, 2018

We've used a html entity since the days of USO e.g.  , or equivalent... food for thought.


How GH renders it today:

With:

 1 | 2 | 3 
 --- | --- | --- 
 one | two | three
 one| | three

Renders:

1 2 3
one two three
one three

... btw last week when I checked #1262 GH wasn't doing it this way... so they changed their runtime spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L2 - annoying Similar to L1 - broken but there is a known workaround available for the issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants