Marked doesn't work with Firefox extension when loaded as content script

[fuweichin]

Describe the bug
Marked doesn't work with Firefox extension when loaded as content script, but other UMD-compliant lib like highlight.js does.

To Reproduce
I have a Firefox extension, in manifest.json,

{
  ...
  "content_scripts": [ {
    "matches": [ "http://*/*", "https://*/*" ],
    "js": [ "libs/marked/0.4.0/marked.js", "libs/highlight.js/9.12.0/highlight.pack.js", "content_script.js" ]
  } ],
  ...
}

and in content_script.js,

console.log(window.marked);
console.log(window.hljs);

Load the extension with Firefox DevTools, the console shows window.marked as undefined, while shows window.hljs as an object .

This happens in Firefox extension but not in Chrome extension.

Expected behavior
It works if I modify slightly on marked's UMD code, from original

;(function(root) {
//...
})(this || (typeof window !== 'undefined' ? window : global));

to

;(function(root) {
//...
})(typeof self !== 'undefined' ? self : this);

which is borrowed from UMD template

[styfle]

Hi @fuweichin
Thanks for reporting this 👍

I checked git blame to see if this has been modified recently but it was actually added in 2012 and basically the same since 09717d7 with one change in 565b4a0 by @Feder1co5oave

Would you like to create a PR to fix this?

[Feder1co5oave]

I believe this is caused by either one of the following:

1. this does not resolve to the global object in the context used by FuweiChin
2. window does not resolve to the global object in that context

It seems that it is safer to use self instead of window (I'm wondering about backward compatibility though), because it works in WebWorkers too.
I'm not sure why this is used to export marked, I guess it should resolve to the global object in some environments but I'm not sure which ones.

(Mozilla content scripts should be allowed to access window, so maybe this does not resolve to it.
Also there's this bug.

[UziTech]

I believe this has been fixed by rollup. if this is still an issue feel free to reopen.