New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
em formatting issues using underscore (_) #1390
Comments
Thanks for reporting this. <p><em>This should be em</em>, but the end is not detected correctly due to the comma.</p>
<p>_If I have some em _, followed by a comma, and then <em>some further em</em> that's detected correctly, the two are combined.</p> <p>_This should be em_, but the end is not detected correctly due to the comma.</p>
<p><em>If I have some em_, followed by a comma, and then _some further em</em> that's detected correctly, the two are combined.</p> |
I believe this is fixed on master. Maybe we should release soon? |
@UziTech I see you copied some results into your comment. Just to keep things very clear here - I think you made a mistake - the CommonMark output I see is this (note the second line is different from yours): <p><em>This should be em</em>, but the end is not detected correctly due to the comma.</p>
<p><em>If I have some em</em>, followed by a comma, and then <em>some further em</em> that's detected correctly, the two are combined.</p> |
looks like this was fixed in 0.6.0 |
Confirmed: my original test cases render correctly now. Thanks for the update! |
Delimiting underscores are not detected correctly if they are followed by commas. Here's a snippet that demonstrates the issue:
The result of passing this text through marked 0.5.2 is this:
As you can see, several underscores are still included in the HTML output, and the two "em" parts in the second paragraph have been combined incorrectly.
The CommonMark Demo formats the output as expected, leaving no underscores in the HTML.
The text was updated successfully, but these errors were encountered: