Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

empty tail on block quotes #8

Closed
puzrin opened this issue Dec 2, 2011 · 4 comments
Closed

empty tail on block quotes #8

puzrin opened this issue Dec 2, 2011 · 4 comments

Comments

@puzrin
Copy link

puzrin commented Dec 2, 2011

If text have 2 empty lines after block quote, then empty line is attached to quoted text after rendering. That should not happen.

http://imm.io/cmoh
@chjj
Copy link
Member

chjj commented Dec 3, 2011

Hmm, @dvv mentioned this the other day in a line comment. It looks like markdown.pl ensures a trailing \n for some reason, but I think you guys are right. It is ugly. I'll have marked slice off the trailing line feed.

@chjj
Copy link
Member

chjj commented Dec 5, 2011

Fixed: c8f26ac

Also pushed to npm.

@chjj chjj closed this as completed Dec 5, 2011
@chjj chjj reopened this Dec 5, 2011
@chjj
Copy link
Member

chjj commented Dec 5, 2011

Also, I'm assuming you were referring to code blocks when you posted this. Not blockquotes. Blockquotes don't grab the trailing line feeds. Let me know if you meant otherwise.

@puzrin
Copy link
Author

puzrin commented Dec 5, 2011

It's ok now, thank you for fix.

@puzrin puzrin closed this as completed Dec 5, 2011
@Feder1co5oave Feder1co5oave mentioned this issue Feb 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@puzrin @chjj