Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easing Implementation #7

Closed
wants to merge 2 commits into from
Closed

Easing Implementation #7

wants to merge 2 commits into from

Conversation

allybee
Copy link

@allybee allybee commented May 14, 2013

Greetings,

Very nice plugin, I'll be using it for my site!

I added a jQuery Easing option for the scrollUp function, e.g.,

$.scrollUp({
  topSpeed: 600,
  easingType: 'easeInCirc'
});

It was just something I desired so I thought I'd share in case you'd like to implement.

I also noticed some spelling errors in your README so I fixed those as well.

Regards,
Allyson

@psenger
Copy link

psenger commented May 14, 2013

Hey Ally that looks nice. I have a fork of this project with grunt/nodejs baked in and some basic tests. fork my project, add your change and we can submit it together with some QUnit tests to Mark and see what he has to say.

@markgoodyear
Copy link
Owner

Hey Allyson,

This looks nice, great addition. As Phil mentions, there's currently a newer version in development. My plan is to wait and compile all the new features into one update (giving credit where it's due), so I'll definitely be adding this in.

How does that sound?

Mark

@allybee
Copy link
Author

allybee commented May 15, 2013

Sounds good, I'll have a look at the other repo then!

@psenger
Copy link

psenger commented May 19, 2013

Im merging it by hand. I should have it merged in shortly. Ally, should I add you as a contributor?

@allybee
Copy link
Author

allybee commented May 19, 2013

Sure! Sorry I haven't been able to check out the other fork. It's been a busy week!

@psenger
Copy link

psenger commented May 19, 2013

I added you. check out the contribute.md. If you wouldn't mind cam you review the changes?

@allybee
Copy link
Author

allybee commented May 19, 2013

Looks great at glance!

@markgoodyear
Copy link
Owner

Added to the upcoming v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants