Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flagging reasons to block list entries. #22

Open
marklindhout opened this issue Aug 22, 2020 · 0 comments
Open

Add flagging reasons to block list entries. #22

marklindhout opened this issue Aug 22, 2020 · 0 comments
Assignees
Labels
feature New feature or request
Milestone

Comments

@marklindhout
Copy link
Owner

Every entry can have multiple reasons for being added to the block list. These reasons need to be attached to the domain’s or URL’s entry in the block list for clarity and display to the user.

A suggestion was provided about how to implement this for list entries. This could look like the following:

const domains = {
  "domain-a.tld": [
    {
      reason: "antisemitism",
      proof: "https://...",
      added: 1598085593878
    }
  ],
  "domain-b.tld": [
    {
      reason: "racism",
      proof: "https://...",
      added: 1598085593878
    },
    {
      reason: "opinion_presented_as_truth",
      proof: "https://...",
      added: 1598085587587
    }
  ]
}

From which the extension could then form presentable strings with i18n methods via the messages.json file, as in the following example:

browser.i18n.getMessage('blockReason_' + domains['domain-a.tld'][0].reason)

and the following value in src/i18n/en/messages.json, for example:

"blockReason_opinion_presented_as_truth": {
  "message": "Opinions or beliefs are being presented as proven truth.",
  "description": "Block reason, according to rule 6: Opinions or beliefs are being presented as proven truth."
},
@marklindhout marklindhout self-assigned this Aug 22, 2020
@marklindhout marklindhout added the feature New feature or request label Aug 22, 2020
@marklindhout marklindhout added this to Triage in Hetzblocker Browser Extension via automation Aug 22, 2020
@marklindhout marklindhout added this to the v1.0.0 milestone Aug 22, 2020
@marklindhout marklindhout moved this from Triage to To do in Hetzblocker Browser Extension Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Development

No branches or pull requests

1 participant