Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

File include for ml-config.xml #235

Closed
rlouapre opened this issue May 5, 2014 · 6 comments
Closed

File include for ml-config.xml #235

rlouapre opened this issue May 5, 2014 · 6 comments

Comments

@rlouapre
Copy link
Contributor

rlouapre commented May 5, 2014

Does Roxy support file include for ml-config.xml?

@dmcassel
Copy link
Collaborator

dmcassel commented May 5, 2014

It does not. Might be an interesting feature. Specific use case you have in mind?

@rlouapre
Copy link
Contributor Author

rlouapre commented May 5, 2014

I am using a shared module across different ML server / application so I would like to have module-locations element in a common file (ideally generated by the shared module).

@grtjn
Copy link
Contributor

grtjn commented May 7, 2014

It is also possible to add module-locations on group level. Unfortunately, Roxy doesn't support much at Group level yet, so module-locations at group level not either..

I like the idea of having the possibility of splitting the large config file. I'm thinking of an <ml:include href="../extra-app-server-config.xml"/> or something alike. I would suggest validating the result. Should be easy to fix setup.xqy to do a validate just before applying changes. Schema is probably predefined.

About actually sharing details across projects: would require specifying paths that go outside the project folder. Might be fragile..

@rlouapre
Copy link
Contributor Author

rlouapre commented May 7, 2014

I think "Sharing details across projects" is not really Roxy responsibility but file include would help us to better organize them.

@dmcassel
Copy link
Collaborator

dmcassel commented May 7, 2014

+1 on that -- the Roxy config is intended for a single project or application (although that may involve multiple app servers or databases). The part about importing a file into ml-config.xml shouldn't be that hard, assuming it's a local file read. Maybe later iterations would allow retrieving it from a remote source.

@grtjn
Copy link
Contributor

grtjn commented Jun 13, 2017

I'd leave getting it from remote to the end users responsibility. There are plenty ways to make sure shared code can be pulled in, for instance using git(hub) submodules.

I'd also like to point to the fact Roxy supports a comma-separated list in the config.file property. Next to that, it also supports so-called shared_config these days: https://github.com/marklogic/roxy/blob/516507b4eb047d0a35a2769d0422fa3cf5a9a978/deploy/sample/build.sample.properties#L29. I think if you combine the two, you can potentially achieve what was looked for here.

I vote closing this ticket. All agree?

@grtjn grtjn closed this as completed Jun 13, 2017
@grtjn grtjn self-assigned this Jun 13, 2017
@grtjn grtjn added the deployer label Jun 13, 2017
@grtjn grtjn added this to the July 2017 milestone Jun 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants