Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

setup.xqy evals with hardwired security database name #309

Closed
sparnell opened this issue Nov 19, 2014 · 6 comments
Closed

setup.xqy evals with hardwired security database name #309

sparnell opened this issue Nov 19, 2014 · 6 comments

Comments

@sparnell
Copy link

Several evals in this module contain:
{xdmp:database("Security")}
which fails if the 'Security' isn't the right database (or doesn't exist)

@grtjn
Copy link
Contributor

grtjn commented Nov 19, 2014

You could patch $default-security at the top of setup.xqy, but some elem or attr, or maybe even a property in build.properties would be much nicer..

@dmcassel
Copy link
Collaborator

Having a default value overridable with a property makes sense. I don't expect this would be used very often, so the default is important, but it makes sense to let someone change it where desired. Shouldn't be hard, I can take this one.

@dmcassel dmcassel self-assigned this Nov 21, 2014
@dmcassel
Copy link
Collaborator

The desired security database will need to be expressed in ml-config.xml somewhere. My guess is that whatever security database is specified for the content database should also be used for the modules database. @sparnell, does that sound like a reasonable assumption?

@grtjn
Copy link
Contributor

grtjn commented Nov 21, 2014

I believe there already is a feature to choose a sec db per database, but it doesnt get applied. There is a comment that says too dangerous..

If it supposed to be generic, then a generic place would make more sense to me. @default-security on top level elem? With overrides on group (new), server or db..

@dmcassel
Copy link
Collaborator

Okay, this is more involved than I thought, and I don't have time to finish it now. I'll come back to this at some point if I can.

@dmcassel dmcassel removed their assignment Aug 24, 2016
@grtjn
Copy link
Contributor

grtjn commented Jun 13, 2017

There are no references to "Security" any more in setup.xqy, except for $default-security. I'm still trying to find a good reason to want to change the Security db. Engineering is highly recommending AGAINST doing so.

Considering closing this ticket..

@grtjn grtjn closed this as completed Jun 13, 2017
@grtjn grtjn self-assigned this Jun 13, 2017
@grtjn grtjn added wontfix and removed enhancement labels Jun 13, 2017
@grtjn grtjn added this to the July 2017 milestone Jun 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants