Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong timeout conversion in awaitCompletion #1637

Closed
hapeka72 opened this issue Feb 14, 2024 · 4 comments
Closed

Wrong timeout conversion in awaitCompletion #1637

hapeka72 opened this issue Feb 14, 2024 · 4 comments
Milestone

Comments

@hapeka72
Copy link

Hi,

the conversion of the timeout in this line is wrong:

It should be like this:
long duration = TimeUnit.MILLISECONDS.convert(timeout, unit);

@rjrudin
Copy link
Contributor

rjrudin commented Feb 14, 2024

Thanks for the report @hapeka72 , we'll look into this today.

@rjrudin
Copy link
Contributor

rjrudin commented Feb 14, 2024

Confirming that your finding is correct. We'll have a fix for this in the next release with tests to ensure that awaitCompletion is honoring the user-defined timeout correctly.

@hapeka72
Copy link
Author

Perfect, thank you!

@rjrudin rjrudin added this to the 6.6.0 milestone Apr 8, 2024
@rjrudin
Copy link
Contributor

rjrudin commented Apr 24, 2024

This will be in the 6.6.0 release this week.

@rjrudin rjrudin closed this as completed Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants