Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rest-properties.json not applied #224

Closed
sparnell opened this issue Aug 7, 2017 · 3 comments
Closed

rest-properties.json not applied #224

sparnell opened this issue Aug 7, 2017 · 3 comments
Milestone

Comments

@sparnell
Copy link

sparnell commented Aug 7, 2017

Change "validate-queries" to false in rest-properties.json. Run mlDeploy. The validate-queries property is still set to true (the default).

@rjrudin
Copy link
Contributor

rjrudin commented Aug 7, 2017

Ack - turns out this is a bug in ml-javaclient-util - the methods are swapped for validate-queries and validate-options:

if (node.has("validate-options")) {
  mgr.setQueryValidation(node.get("validate-options").asBoolean());
}
if (node.has("validate-queries")) {
  mgr.setQueryOptionValidation(node.get("validate-queries").asBoolean());
}

@rjrudin
Copy link
Contributor

rjrudin commented Aug 7, 2017

I'm about to publish ml-gradle 2.9.0 - I'll make a 2.14.1 of ml-javaclient-util and include the bugfix in there, so it'll be part of 2.9.0. Thanks for the report.

@rjrudin
Copy link
Contributor

rjrudin commented Aug 7, 2017

Fixed and including in ml-gradle 2.9.0

@rjrudin rjrudin closed this as completed Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants