Orphaned Amps Fix

[mustard57]

Hello

If you do a bootstrap using a modules db, then switch your config to use 'filesystem' as the modules db ( bootstrap after doing this ) , then do a wipe, any amps belonging to the original modules db will get orphanned - you can see this in the 'Amps' page as the amp in question will have a number as the 'database'.

If this happens, you will get an error in setup:get-amps when you next bootstrap near this line

xdmp:database-name($amp/sec:database)

as the db no longer exists. The manual fix is to delete the offending amp.

This is the error you will get

Bootstrapping your project into MarkLogic on localhost...
ERROR: [{"qid":null, "type":"string", "result":"XDMP-NODB: xdmp:database-name(sec:id(\"510626068934067422\")) -- No database with identifier 510626068934067422\nSee MarkLogic Server error log for more details."}]
ERROR: ... Bootstrap FAILED

The code fix ( below ) is to ignore it.

diff --git a/deploy/lib/xquery/setup.xqy b/deploy/lib/xquery/setup.xqy
index 8e58cc6..440306f 100644
--- a/deploy/lib/xquery/setup.xqy
+++ b/deploy/lib/xquery/setup.xqy
@@ -4259,6 +4259,8 @@ declare function setup:get-amps($ids as xs:unsignedLong*)
     <amps xmlns="http://marklogic.com/xdmp/security">
     {
       for $amp in $amps
+      (: Avoid errors if amp is 'orphanned' :)
+      where $amp/sec:database = xdmp:databases()
       return
         element sec:amp
         {

Note if you try to re-create the error you may get SEC-AMPEXISTS after you have reproduced then added the patch - this is a consequence of the fact that the original error does not get rolled back. However if you undo what you got when trying to recreate the error, then try and recreate the error having applied the patch, the patch fixes. That may or may not be clear.

[dmcassel]

I think rather than a where clause, an if/then with the same check could produce a more informative error instead of quietly letting it go.

[grtjn]

I suspect this error also appears if you create an amp with Roxy, and then remove the amp from the ml-config, without doing a wipe first. Then, if you wipe the entire project the amp will get left behind, but with an invalid database ref..

[grtjn]

I agree letting it go quietly is a missed opportunity to report something. Not sure throwing an error is the best solution though. The amp might be unrelated to the project that you try to bootstrap, bit hard to tell. Easiest to tell by db-name, and that is precisely what is missing. I'll push a change that will log a message in the ErrorLog. That is at least something..

[mustard57]

I wrote this for getting rid of dead amps, if that's at all helpful.

This is largely the problem here I think.

Ken

[grtjn]

Applied formatting to code from Ken:

let $script :=
'xquery version "1.0-ml";

declare namespace sec="http://marklogic.com/xdmp/security";

declare function local:db-exists($id) as xs:boolean
{
  if($id = 0) then fn:true()
  else
  try{
    xdmp:database-name($id)[0],fn:true()
  }
  catch($ex){
    fn:false()
  }
};

let $dead-amps := /sec:amp[fn:not(local:db-exists(./sec:database))]
return
(
for $dead-amp in $dead-amps
return
xdmp:document-delete($dead-amp)
,
xdmp:log(fn:count($dead-amps)||" dead amps removed")
)
'
return
xdmp:eval($script,(),<options
xmlns="xdmp:eval"><database>{xdmp:database("Security")}</database></options>)

[grtjn]

I think it could be worth looking if this could be integrated into wipe. I'll open a new ticket since this ticket was about bootstrapping..