Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

Ignore empty settings in version-check #398

Closed
grtjn opened this issue Feb 26, 2015 · 3 comments
Closed

Ignore empty settings in version-check #398

grtjn opened this issue Feb 26, 2015 · 3 comments
Labels
Milestone

Comments

@grtjn
Copy link
Contributor

grtjn commented Feb 26, 2015

Ignore <rewrite-resolves-globally>@ml.rewrite-resolves-globally</rewrite-resolves-globally> entirely if propery is empty..

@grtjn grtjn added the bug label Feb 26, 2015
@grtjn grtjn added this to the 1.7.2 milestone Feb 26, 2015
@grtjn
Copy link
Contributor Author

grtjn commented Feb 26, 2015

Just a matter of adding [fn:string(.) != ''] when data is retrieved

@grtjn
Copy link
Contributor Author

grtjn commented Feb 26, 2015

Correction, empty values are suppressed, replacing vars goes wrong. sample ml-config is bad. This:

<rewrite-resolves-globally>@ml.rewrite-resolves-globally</rewrite-resolves-globally>

Should be:

@ml.rewrite-resolves-globally

@grtjn
Copy link
Contributor Author

grtjn commented Feb 26, 2015

Additionally:

if @properties['ml.rewrite-resolves-globally'].present?

Should be:

if !@properties['ml.rewrite-resolves-globally'].nil?

grtjn added a commit to grtjn/roxy that referenced this issue Mar 5, 2015
paxtonhare added a commit that referenced this issue Mar 10, 2015
Fixed #398: bug in sample ml-config, and server_config
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants