This repository has been archived by the owner on Nov 9, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 66
Allow same prop replace syntax in props and ml-config #467
Labels
Milestone
Comments
It will have to be backwards-compatible, which means doing two passes. Not sure how many places that happens in the code. Hopefully only once, in which case, no big deal. It would be less confusing. |
Any particular reason to have the ml. prefix in ml-config? |
grtjn
added a commit
to grtjn/roxy
that referenced
this issue
Jun 30, 2015
grtjn
added a commit
to grtjn/roxy
that referenced
this issue
Jul 8, 2015
grtjn
added a commit
to grtjn/roxy
that referenced
this issue
Jul 8, 2015
dmcassel
added a commit
that referenced
this issue
Jul 13, 2015
Fixed #467: allowed multiple prop replace syntax
Fixed in dev |
grtjn
added a commit
to grtjn/roxy
that referenced
this issue
Jan 28, 2016
grtjn
added a commit
to grtjn/roxy
that referenced
this issue
Jan 28, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In properties files you use ${app-name}, in ml-config you use @ml.app-name. The difference is confusing to my opinion. And not adding { } in ml-config makes people believe @ml.app-name-rest-modules is a full property name, where it actually is just a partial one (@ml.app-name + '-rest-modules').
I vote for adding different syntax to ml-config as well, preferably ${propname} like in properties themselves, alternatively @{ml.propname}. Thoughts?
The text was updated successfully, but these errors were encountered: