Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

Make http timeout configurable #470

Closed
grtjn opened this issue Jun 23, 2015 · 1 comment
Closed

Make http timeout configurable #470

grtjn opened this issue Jun 23, 2015 · 1 comment
Milestone

Comments

@grtjn
Copy link
Contributor

grtjn commented Jun 23, 2015

Something like:

HTTP_CONNECTION_READ_TIMEOUT = ENV['HTTP_CONNECTION_READ_TIMEOUT'] ? ENV['HTTP_CONNECTION_READ_TIMEOUT'].to_i : 300

If you wanted to use the ENV vars.

If you meant from properties files then it would be something like:

MLClient.rb:
@http = Roxy::Http.new({
:logger => logger
:http_connection_read_timeout => options[:http_connection_read_timeout]
})

You would just have to pass the timeout around to a few places to get it into the Roxy::Http class.

@grtjn grtjn added this to the 1.7.3 milestone Jun 23, 2015
grtjn added a commit to grtjn/roxy that referenced this issue Jun 29, 2015
grtjn added a commit to grtjn/roxy that referenced this issue Jun 29, 2015
dmcassel added a commit that referenced this issue Jul 8, 2015
Fixed #470: allow overriding http timeout settings from props
@dmcassel
Copy link
Collaborator

dmcassel commented Jul 8, 2015

Fixed in dev

@dmcassel dmcassel closed this as completed Jul 8, 2015
grtjn added a commit to grtjn/roxy that referenced this issue Jan 28, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants