Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

support custom properties for corb2 #521

Closed
joemfb opened this issue Sep 21, 2015 · 4 comments
Closed

support custom properties for corb2 #521

joemfb opened this issue Sep 21, 2015 · 4 comments
Labels
enhancement
Milestone
v1.7.4

Comments

@joemfb
Copy link
Contributor

joemfb commented Sep 21, 2015

It'd be nice if we could pass custom properties to corb: https://stackoverflow.com/questions/31751243/marklogic-8-corb-pass-arguments-other-than-uri

Also, we should probably be bundling/supporting corb2, if we're not already ...
@grtjn grtjn added this to the 1.7.4 milestone Sep 21, 2015
@grtjn
Copy link
Contributor

grtjn commented Sep 21, 2015

If I read and remember correctly, corb doesn't support such properties, so this means we would have to implement support for corb2 then. Makes sense..

@joemfb joemfb changed the title support custom properties for corb support custom properties for corb2 Sep 21, 2015
hansenmc added a commit to hansenmc/roxy that referenced this issue Jul 14, 2016
@hansenmc
Fixing Issue marklogic-community#521: support custom properties for C…
9809527 
…oRB2

Updated the corb task to use CoRB2 v2.3.1 and support all of the CoRB2 options.

Ensured that the current Roxy commandline options and functionality still work,
and also support specifying any of the CoRB2 options with either "--" or "-D"
prefix, case-insensitive (i.e. --options-file or -DOPTIONS-FILE).

Removed the explicit checks/errors for Roxy corb task required fields, since there
are now additional options available: URIS-FILE, XML-FILE, PROCESS-MODULE (now 
preferred instead of XQUERY-MODULE), specifying all options inside of 
OPTIONS-FILE, etc.

Also upgraded the XCC jar to v8.0.5
@hansenmc hansenmc mentioned this issue Jul 15, 2016
Merged
grtjn added a commit that referenced this issue Jul 19, 2016
@grtjn
Merge pull request #626 from hansenmc/issue521
54c1f74 
Fixing Issue #521: support custom properties for CoRB2
@dmcassel
Copy link
Collaborator

@hansenmc with your pull request, this issue can be closed, right?

@hansenmc
Copy link
Member

hansenmc commented Jul 21, 2016 •
edited
Loading

Definitely if the custom properties are set in an options file, but I think I may need to make a slight adjustment to ensure that if passed in via commandline, a lower or camelCased property does not get turned into UPPER-CASE (e.g. URIS-MODULE.foo => URIS-MODULE.FOO). We want to ensure the base option is upper-case, but preserve case for the custom property. I can get that added this evening.

@hansenmc hansenmc mentioned this issue Aug 19, 2016
Merged
@grtjn
Copy link
Contributor

grtjn commented Aug 19, 2016

Above mentioned fix was added and merged, and latest corb jar with usage included as well!

@grtjn grtjn closed this as completed Aug 19, 2016
@grtjn grtjn removed the help wanted label Aug 19, 2016
@hansenmc hansenmc mentioned this issue Aug 23, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v1.7.4
Development

No branches or pull requests
4 participants
@grtjn @dmcassel @joemfb @hansenmc