Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

Toggling the Run/Run All Tests checkboxes don't update the active styling for tests #570

Closed
rhdunn opened this issue Feb 26, 2016 · 4 comments

Comments

@rhdunn
Copy link
Contributor

rhdunn commented Feb 26, 2016

Overview

For both the Test Suite and tests for a given test suite lists, toggling the Run/Run All Tests checkbox does not toggle the active state for the affected items (test suites and tests respectively). They are toggled when using the per-item checkboxes.

Use Case

As a user running roxy-based unit tests, I want to easily see which tests will be run using the "Run Tests" button.

System

Roxy Version: 1.6
Operating System: Windows
Web Browser: Firefox

@dmcassel
Copy link
Collaborator

dmcassel commented Mar 4, 2016

Hi @rhdunn. Looking at the "Framework Tests" suite as an example, if you uncheck the top-level checkbox, the individual test checkboxes don't change, but that suite will not be run when you click "Run Tests". If that top-level checkbox is checked, any selected tests under that suite will be run.

I get what you're saying, that you anticipated that the individual test check boxes would get cleared when a suite's checkbox gets unchecked. I think that the original intent was that you could select some tests within a suite, and then checking or unchecking the suite-level box would preserve your choice, while still controlling whether that suite was run. (sound right, @paxtonhare?) With that in mind, I think the top-level checkbox does easily show which test suites will be run.

Further comments welcome.

@rhdunn
Copy link
Contributor Author

rhdunn commented Mar 4, 2016

I don't mind (and like) preserving the checkbox state. I am referring to the CSS used to make checked items black and unchecked items gray -- that logic does not match the checkbox state.

@dmcassel
Copy link
Collaborator

dmcassel commented Mar 4, 2016

Ah, I see what you mean. Thanks for clarifying.

@dmcassel dmcassel added the bug label Mar 4, 2016
rhdunn pushed a commit to rhdunn/roxy that referenced this issue Jul 15, 2016
…in /test.

This ensures that the disabled style is set correctly when the user
toggles the run all tests and run all test suites checkboxes.
dmcassel added a commit that referenced this issue Jul 20, 2016
Fix #570 Update the disabled style after checkall in /test.
@dmcassel
Copy link
Collaborator

fixed in dev

@dmcassel dmcassel added this to the 1.7.4 milestone Jul 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants