Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

Space in Ruby Path causes ml.bat to fail #601

Closed
rjkennedy98 opened this issue Apr 22, 2016 · 6 comments
Closed

Space in Ruby Path causes ml.bat to fail #601

rjkennedy98 opened this issue Apr 22, 2016 · 6 comments

Comments

@rjkennedy98
Copy link

After doing Roxy upgrade to 1.7.3 master the ml.bat script fails in windows.

C:\EDH_ML_Path4_3\eie_edh_framework\EDH_ML>C:\Program Files (x86)\Ruby21\bin\rub
y.exe -Ideploy -Ideploy\lib deploy\lib\ml.rb
'C:\Program' is not recognized as an internal or external command,
operable program or batch file.

@dmcassel
Copy link
Collaborator

I don't have a Windows setup handy. @rjkennedy98 could you run a quick test? In ml.bat, line 12, add quotes around the value for RUBYFOUND, so that it looks like this:

set RUBYFOUND="%%~$PATH:X"

If that works, we can update the script. If not, I invite input from someone with more Windows scripting fu than I have.

@rjkennedy98
Copy link
Author

That gave me:
C:\EDH_ML_Path4_3\eie_edh_framework\EDH_ML>ml local deploy modules
'""' is not recognized as an internal or external command,

I have made a change ml.bat, line 158
"%RUBYFOUND%" -Ideploy -Ideploy\lib -Ideploy\test deploy\test\test_main.rb

and ml.bat, line 167
"%RUBYFOUND%" -Ideploy -Ideploy\lib deploy\lib\ml.rb %*

that seemed to resolve issue

@dmcassel dmcassel added this to the 1.7.4 milestone Apr 28, 2016
dmcassel added a commit to dmcassel/roxy that referenced this issue Apr 28, 2016
@rlouapre
Copy link
Contributor

I am not sure we should have provided a fix for it...
Screen from Ruby installer:
image
It clearly says "please avoid any folder name that contains spaces"

@dmcassel
Copy link
Collaborator

@rlouapre interesting find. While I agree with you -- the instructions are pretty clear -- it's a pretty simple fix for Roxy. Might as well.

@rjkennedy98
Copy link
Author

The client I am working with has managed VMs which have a space in the ruby install path. Otherwise, yes, it could be easily avoided by following directions.

dmcassel added a commit that referenced this issue May 25, 2016
#601 adding quotes around the ruby path
@grtjn
Copy link
Contributor

grtjn commented May 25, 2016

Fixed in dev..

@grtjn grtjn closed this as completed May 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants