Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

Transactional Unit Tests always succeed #667

Closed
ghost opened this issue Oct 4, 2016 · 3 comments
Closed

Transactional Unit Tests always succeed #667

ghost opened this issue Oct 4, 2016 · 3 comments
Assignees
Milestone

Comments

@ghost
Copy link

ghost commented Oct 4, 2016

Following this: https://github.com/marklogic/roxy/wiki/Transactional-Unit-Tests

The unit test I run fails and created a log entry detailing this, that is correct. But ROXY does not show this test as failed, it return success.

Maybe this has something to do with the try/catch in the transactional test setup?

@dmcassel
Copy link
Collaborator

Verified using the second approach listed on the wiki page. The last transaction needs to return the result of calling assert in order for the results to be counted. I think the fix here will probably be to document a better way to write the test.

@dmcassel
Copy link
Collaborator

@Thijxx you were right, it was the try/catch. I've updated the sample code on the wiki. Would you mind a quick review?

@dmcassel dmcassel added this to the 1.7.4 milestone Oct 18, 2016
@ghost
Copy link
Author

ghost commented Oct 20, 2016

Works fine now with the rethrow, thanks.

@ghost ghost closed this as completed Oct 20, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant