Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

Exit code on windows. #680

Closed
eurochriskelly opened this issue Oct 22, 2016 · 3 comments
Closed

Exit code on windows. #680

eurochriskelly opened this issue Oct 22, 2016 · 3 comments

Comments

@eurochriskelly
Copy link

Hi,

I ran into an issue while trying to automate roxy using nodejs. Basically, on windows, the batch file does not return the correct exit code to the program. I fixed by adding the following last line to ml.bat

exit /b %errorlevel%

Would it be possible to add this permanently?

@RobertSzkutak
Copy link
Contributor

RobertSzkutak commented Oct 23, 2016

Good suggestion! Offhand, did you notice if the *.sh file returns the correct exit code? There was at least one old issue to get this right and I'd like to make sure it works in both the *.bat and *.sh. PRs welcome :)

@RobertSzkutak RobertSzkutak added this to the 1.7.5 milestone Oct 23, 2016
@eurochriskelly
Copy link
Author

Yes. *,sh version worked perfectly! I will make a PR

@dmcassel
Copy link
Collaborator

fixed in dev

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants