Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

use-https should control use of https for REST configuration #753

Closed
jkerr5 opened this issue Mar 27, 2017 · 1 comment
Closed

use-https should control use of https for REST configuration #753

jkerr5 opened this issue Mar 27, 2017 · 1 comment

Comments

@jkerr5
Copy link

jkerr5 commented Mar 27, 2017

Short description of the problem:

Even with the "use-https=true" property set, REST configuration does not use https unless the "ml.ssl-certificate-template" property is set to something (it can be set to anything).

This is checked here: https://github.com/marklogic/roxy/blob/master/deploy/lib/server_config.rb#L2173

This is mainly relevant where a proxy or load balancer sits in front of MarkLogic and uses https to clients but http to MarkLogic. Because there is no ssl configuration on the MarkLogic side, "ml.ssl-certificate-template" would not be set.

Shouldn't the REST use https if the "use-https=true" property is set?

What are the steps to reproduce the problem?

In the deploy/build.properties

  1. Set "use-https=true"
  2. Make sure "ml.ssl-certificate-template" is commented out
  3. Add REST configuration files in the rest-api directory
  4. run ./ml deploy modules

Tech Specs

Which Operating System are you using?
Linux

Which version of MarkLogic are you using?
8.0-6.3

Which version of Roxy are you using (see version.txt)?
1.7.3+

@dmcassel dmcassel added this to the April 2017 milestone Mar 28, 2017
@RobertSzkutak RobertSzkutak modified the milestones: July 2017, April 2017 May 5, 2017
@grtjn grtjn self-assigned this May 26, 2017
@grtjn grtjn modified the milestones: April 2017, July 2017 May 26, 2017
RobertSzkutak added a commit that referenced this issue May 31, 2017
Fixed #753: added new use-https-for-rest property
@grtjn
Copy link
Contributor

grtjn commented May 31, 2017

Fixed in dev

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants