New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong extension when contains number #33

Open

jbeaven opened this issue Jun 9, 2017 · 1 comment

jbeaven commented Jun 9, 2017

The regex only matches alpha characters. For extensions such as mp4, this results in "mp". The regex should be changed from:

var ext = url.match(/.[a-z]{1,}/g);

to

var ext = url.match(/.[a-z0-9]{1,}/g);

Other non-alphanumeric values may also be valid..

marcopeg commented Aug 11, 2017

Yes, caching with mp4 it is seems broken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment