Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download fails on Android when url's contain '../' in it #7

Closed
starquake opened this issue May 15, 2015 · 2 comments · Fixed by #8
Closed

Download fails on Android when url's contain '../' in it #7

starquake opened this issue May 15, 2015 · 2 comments · Fixed by #8

Comments

@starquake
Copy link
Contributor

Download fails on Android when url's contain '../' in it. I'm not entirely sure but IIRC this doesn't seem to be an issue on iOS.

I want to make a PR with a fix but I wanted to check with you if you agree with me that this should be fixed in the function 'normalize'.

Is it okay with you if I improve the function normalize so that it will return a normalized path?

Like this:
"http://10.10.1.104:9000/site//Mobile/../css/tinymce-content.css"
into
"http://10.10.1.104:9000/site/css/tinymce-content.css"

@starquake
Copy link
Contributor Author

Mmmm I'm starting to think this actually might be a bug in 'cordova-plugin-file-transfer'

@markmarijnissen
Copy link
Owner

Would be wonderful if you enhance the normalize function! If you do, please submit a pull request and I'll try to merge within a week. (in the weekends)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants