Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Global Dark Mode Toggle #217

Closed
rohitbulusu opened this issue Nov 22, 2022 · 1 comment
Closed

[FEATURE] Global Dark Mode Toggle #217

rohitbulusu opened this issue Nov 22, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@rohitbulusu
Copy link

Is your feature request related to a problem? Please describe.
My feature request isn't related to a problem but more of an additional feature/functionality. I think it would be really cool if the site in general had a dark mode toggle. Either one that works globally across the entire site or across components individually.

Describe the solution you'd like
I would like to contribute if possible by adding a global dark mode toggle at the top right of the site, which looks for any tailwind classes marked with dark: and then if that goes well add dark mode variants to some components..

Describe alternatives you've considered
I was thinking of either Global Dark mode, which can perhaps be placed at the top right of the website, built with a nice slider, which applies it globally across the whole site and also each component, or at a component level where each one can have a dark mode toggle, but would like to know your thoughts on this.

Additional context
Add any other context or screenshots about the feature request here.

@rohitbulusu rohitbulusu added the enhancement New feature or request label Nov 22, 2022
@markmead markmead changed the title Global Dark Mode Toggle/ Component Level Dark mode toggle [FEATURE] Global Dark Mode Toggle Nov 23, 2022
@markmead
Copy link
Owner

Hi, @rohitbulusu thanks for your thoughts on this. Sadly, this is unlikely to make it into HyperUI at the moment due to not all components having a dark mode variant which will cause confusion for users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants