Date Issued not showing on certificate

[meggatrron]

I'm new to Git so don't blast me if this is the wrong place to post this. I'm working in Moodle 3.3 and have designed a certificate. When logged in as a student (not just the student role) and after completing the requisite lesson, the certificate prinss without showing the date. I've tried the different date modes available with no luck. Any help?

[mdjnelson]

What happens when you edit the date element? Does it display when you preview it?

[meggatrron]

Hi Mark, Yes, when I edit the element and "Save and Preview" I get the current date irrespective of which type of date I set it at. Thanks for your help and a great plugin. I plan on contributing to the cause!!

…

----- Original Message ----- From: "Mark Nelson" <notifications@github.com> To: "markn86/moodle-mod_customcert" <moodle-mod_customcert@noreply.github.com> Cc: "meggatrron" <rvpierce@comcast.net>, "Author" <author@noreply.github.com> Sent: Wednesday, June 21, 2017 2:45:07 AM Subject: Re: [markn86/moodle-mod_customcert] Date Issued not showing on certificate (#118) What happens when you edit the date element? Does it display when you preview it? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub , or mute the thread .

[meggatrron]

Hi Mark, Have you made any discovery on this issue? Ray

…

----- Original Message ----- From: "Mark Nelson" <notifications@github.com> To: "markn86/moodle-mod_customcert" <moodle-mod_customcert@noreply.github.com> Cc: "meggatrron" <rvpierce@comcast.net>, "Author" <author@noreply.github.com> Sent: Wednesday, June 21, 2017 2:45:07 AM Subject: Re: [markn86/moodle-mod_customcert] Date Issued not showing on certificate (#118) What happens when you edit the date element? Does it display when you preview it? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub , or mute the thread .

[sstoppi]

Hi Mark,

I have the same problem. I would like to have the Completion Date of the created test of the course, but it doesn't work. ("Topic 3: Test", like shown in the screen Shot). The date only gets displayed when I'm logged in as admin and click the "Save changes and preview".
Any help?

Thanks, Sara

[sstoppi]

Hi Mark,

do you have updates on this? Thanks,

Sara

[mdjnelson]

Hi Sara,

Have you had a look at #113?

[mdjnelson]

Hi Ray,

I will be working on issues next week for this plugin, so expect an update then. Cheers for your patience.

(Note - I have been overseas for a few weeks and majority of the time I did not have access to the internet, sorry for the late reply).

[meggatrron]

No worries Mark. Your Custom Certificate Plugin is absolutely awesome! I have been working with it as is using the "Date Printed" until you figure out what it needs. Thank you.

…

----- Original Message ----- From: "Mark Nelson" <notifications@github.com> To: "markn86/moodle-mod_customcert" <moodle-mod_customcert@noreply.github.com> Cc: "meggatrron" <rvpierce@comcast.net>, "Author" <author@noreply.github.com> Sent: Sunday, July 30, 2017 9:44:04 PM Subject: Re: [markn86/moodle-mod_customcert] Date Issued not showing on certificate (#118) Hi Ray, I will be working on issues next week for this plugin, so expect an update then. Cheers for your patience. (Note - I have been overseas for a few weeks and majority of the time I did not have access to the internet, sorry for the late reply). — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub , or mute the thread .

[mdjnelson]

Hi Ray,

I did the following -

1. Enabled completion on the site.
2. Created a new course with a start and end date.
3. Enrolled a student into the course.
4. Added an assignment to the course and set it so it was marked as complete when a student made a submission.
5. Set the course completion to be dependent on this activity being set.
6. Created a custom certificate with 5 date elements (every option available).
7. Logged in as the student and downloaded the certificate.
   • The only dates being shown were the course start date, course end date and the issue date.
8. Submitted the assignment.
9. Ran the site cron.
10. As the student I downloaded the certificate again.
    • The only dates being shown were the course start date, course end date, completion date and the issue date.

I then wondered why the date of the assignment was not displaying and had a look at the code. It is supposed to display the date that it was graded but this isn't possible because the function it is calling only returns the grade. So there is indeed a bug!

Working on fix now.

[mdjnelson]

This has been fixed now. I will update the plugin in the Moodle plugins DB at the end of the week. Thanks for your patience and the report.

[meggatrron]

Thank you for the update Mark!!

…

----- Original Message ----- From: "Mark Nelson" <notifications@github.com> To: "markn86/moodle-mod_customcert" <moodle-mod_customcert@noreply.github.com> Cc: "meggatrron" <rvpierce@comcast.net>, "Author" <author@noreply.github.com> Sent: Monday, August 7, 2017 10:32:13 PM Subject: Re: [markn86/moodle-mod_customcert] Date Issued not showing on certificate (#118) Hi Ray, I did the following - 1. Enabled completion on the site. 2. Created a new course with a start and end date. 3. Enrolled a student into the course. 4. Added an assignment to the course and set it so it was marked as complete when a student made a submission. 5. Set the course completion to be dependent on this activity being set. 6. Created a custom certificate with 5 date elements (every option available). 7. Logged in as the student and downloaded the certificate. * The only dates being shown were the course start date, course end date and the issue date. 8. Submitted the assignment. 9. Ran the site cron. 10. As the student I downloaded the certificate again. * The only dates being shown were the course start date, course end date, completion date and the issue date. I then wondered why the date of the assignment was not displaying and had a look at the code. It is supposed to display the date that it was graded but this isn't possible because the function it is calling only returns the grade. So there is indeed a bug! Working on fix now. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub , or mute the thread .

[piteko]

Hi,
I saw that you fixed and published two different commits respectively for the 3.2 and 3.3 moodle version. Is there a commit for the moodle 3.1 plugin (which is the only long-term release)?
Thanks!
Marcello

[mdjnelson]

Hi Marcello,

Since I develop this in my own time I only support versions that align with the Moodle release - having an additional version to test is time consuming. Also, this is not a security issue which is why I never backported it. Feel free to cherry-pick the commit for you to use.

Sorry. :)