fix: add devmode warning for removing fragment markers #1541
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds additional checks in dev mode to give more context to the user as to why diffing failed when the DOM has been updated manually and fragment markers (empty text nodes) were removed.
Instead of throwing
TypeError: Cannot read property 'nextSibling' of null
, it now throwsError: Cannot get fragment nodes. Boundary markers missing.
. In addition to the new error text, a second error is passed toconsole.warn
showing the location where the fragment marker was removed.Checklist: