Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: split components under preserved root resetting the preserve #1559

Merged
merged 1 commit into from Apr 23, 2020

Conversation

mlrawlings
Copy link
Member

Description

Split components did not have the parent's preserved value attached to them, but in endComponent we're setting the current ___isPreserved back to the parent's value regardless of whether the current component was split.

This caused a split component to set the ___isPreserved back to undefined, which meant any components after this would not be hydrated.

This fixes the issue by ensuring all components that render boundaries have their parent's ___isPreserved value.

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@codecov
Copy link

codecov bot commented Apr 23, 2020

Codecov Report

Merging #1559 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1559   +/-   ##
=======================================
  Coverage   90.54%   90.54%           
=======================================
  Files         355      355           
  Lines       12764    12764           
=======================================
  Hits        11557    11557           
  Misses       1207     1207           
Impacted Files Coverage Δ
...ges/marko/src/runtime/components/beginComponent.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eb76ff...f88ecdb. Read the comment docs.

@mlrawlings mlrawlings merged commit 03bb099 into master Apr 23, 2020
DylanPiercey pushed a commit that referenced this pull request Apr 27, 2020
@DylanPiercey DylanPiercey deleted the fix-split-preserve branch January 26, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant