fix: split components under preserved root resetting the preserve #1559
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split components did not have the parent's preserved value attached to them, but in
endComponent
we're setting the current___isPreserved
back to the parent's value regardless of whether the current component was split.This caused a split component to set the
___isPreserved
back to undefined, which meant any components after this would not be hydrated.This fixes the issue by ensuring all components that render boundaries have their parent's
___isPreserved
value.Checklist: