Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue with data-marko attributes under 'no-update' with <await> #1564

Merged
merged 1 commit into from Apr 30, 2020

Conversation

DylanPiercey
Copy link
Contributor

Description

There was a regression from #1480 which would cause no-update body to loose track of if it was preserved when it was wrapped in an async writer (<await>).

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@DylanPiercey DylanPiercey force-pushed the fix-data-marko-across-async-context branch from a82671f to 1cab05a Compare April 30, 2020 19:53
@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #1564 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1564   +/-   ##
=======================================
  Coverage   90.54%   90.54%           
=======================================
  Files         355      355           
  Lines       12769    12769           
=======================================
  Hits        11562    11562           
  Misses       1207     1207           
Impacted Files Coverage Δ
packages/marko/src/runtime/html/AsyncStream.js 89.41% <ø> (ø)
...arko/src/compiler/ast/HtmlElement/html/StartTag.js 98.14% <100.00%> (ø)
...kages/marko/src/runtime/html/helpers/data-marko.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f793a99...1cab05a. Read the comment docs.

@DylanPiercey DylanPiercey merged commit 211a8a3 into master Apr 30, 2020
@DylanPiercey DylanPiercey deleted the fix-data-marko-across-async-context branch April 30, 2020 20:02
DylanPiercey added a commit that referenced this pull request May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant